WIP: Fix for #109, add toggle state to buttons
#112
Draft
Moiety
wants to merge 1 commits from toggle-buttons-#109
into develop
Loading…
Reference in New Issue
There is no content yet.
Delete Branch 'toggle-buttons-#109'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Adds aria-pressed to the “Options” toggle buttons; this communicates their state to assistive technologies.
@ -134,0 +135,4 @@
if (active == 'false') {
currentOption.setAttribute('data-active', 'true');
currentOption.setAttribute('aria-pressed', 'true');
}
We originally intended to change all
data-active
toaria-pressed
because technically the action is already correct, just on the wrong attribute. We couldn’t quite figure out the way the CSS was generated and decided to keep it simple. Feel free to change.The CSS doesn't render. I changed it a few weeks back to just be pure CSS that lives in the
public/assets
directory. The style directory full of SCSS files is legacy that I use to reference from time to time, but it's not used by the build anymore.I appreciate the hold off. This is pretty significant change that affects the CSS as well, so I'll more than likely make that change as I redo the CSS and remove all of the invalid
role
attributes I used through out.Fix for #109, add toggle state to buttonsto WIP: Fix for #109, add toggle state to buttons 1 year agoThe current implementation doesn’t rely on any CSS changes; both the
data-active
andaria-pressed
are still present. If you want this is ready to go!Reviewers
Step 1:
From your project repository, check out a new branch and test the changes.Step 2:
Merge the changes and update on Forgejo.