WIP: Fix for #109, add toggle state to buttons #112

Draft
Moiety wants to merge 1 commits from toggle-buttons-#109 into develop
Moiety commented 1 year ago
Collaborator

Adds aria-pressed to the “Options” toggle buttons; this communicates their state to assistive technologies.

Adds aria-pressed to the “Options” toggle buttons; this communicates their state to assistive technologies.
Moiety added the
Accessibility
label 1 year ago
are0h was assigned by Moiety 1 year ago
Moiety added 1 commit 1 year ago
a687b50452 Fix for #109, add toggle state to buttons
Adds aria-pressed to the “Options” toggle buttons; this communicates their state to assistive technologies.
Moiety reviewed 1 year ago
@ -134,0 +135,4 @@
if (active == 'false') {
currentOption.setAttribute('data-active', 'true');
currentOption.setAttribute('aria-pressed', 'true');
}
Moiety commented 1 year ago
Poster
Collaborator

We originally intended to change all data-active to aria-pressed because technically the action is already correct, just on the wrong attribute. We couldn’t quite figure out the way the CSS was generated and decided to keep it simple. Feel free to change.

We originally intended to change all `data-active` to `aria-pressed` because technically the action is already correct, just on the wrong attribute. We couldn’t quite figure out the way the CSS was generated and decided to keep it simple. Feel free to change.
are0h was unassigned by Moiety 1 year ago
Moiety requested review from are0h 1 year ago
are0h commented 1 year ago
Owner

The CSS doesn't render. I changed it a few weeks back to just be pure CSS that lives in the public/assets directory. The style directory full of SCSS files is legacy that I use to reference from time to time, but it's not used by the build anymore.

I appreciate the hold off. This is pretty significant change that affects the CSS as well, so I'll more than likely make that change as I redo the CSS and remove all of the invalid role attributes I used through out.

The CSS doesn't render. I changed it a few weeks back to just be pure CSS that lives in the `public/assets` directory. The style directory full of SCSS files is legacy that I use to reference from time to time, but it's not used by the build anymore. I appreciate the hold off. This is pretty significant change that affects the CSS as well, so I'll more than likely make that change as I redo the CSS and remove all of the invalid `role` attributes I used through out.
are0h changed title from Fix for #109, add toggle state to buttons to WIP: Fix for #109, add toggle state to buttons 1 year ago
Moiety commented 1 year ago
Poster
Collaborator

The current implementation doesn’t rely on any CSS changes; both the data-active and aria-pressed are still present. If you want this is ready to go!

The current implementation doesn’t rely on any CSS changes; both the `data-active` and `aria-pressed` are still present. If you want this is ready to go!

Reviewers

are0h was requested for review 1 year ago
This pull request has changes conflicting with the target branch.
  • public/assets/scripts/dash.js.map
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b toggle-buttons-#109 develop
git pull origin toggle-buttons-#109

Step 2:

Merge the changes and update on Forgejo.
git checkout develop
git merge --no-ff toggle-buttons-#109
git push origin develop
Sign in to join this conversation.
Loading…
There is no content yet.