New Issue

`<button>`s under “Options” don’t have their status communicated programatically #109

Open

opened by Moiety · 0 comments

Moiety commented

Collaborator

Where: Add/Edit page

What: The <button>s under “Options” don’t have their status communicated programatically

Recommendation: Apply the APG toggle button pattern to things like the “Publish”; its use of aria-pressed will make sure assistive technologies known the status of the buttons.

Note: the “B”, “I”, and “S” buttons in the “Editor toolbar” would usually also classify as toggle buttons. But it looks like these only activate formatting behaviour rather than also deactivating it.

before “bold” activation

2. after “bold” activation and selecting the text again

3. after activating “bold” once more, the markdown is added twice rather than deactivated

Where: Add/Edit page What: The `<button>`s under “Options” don’t have their status communicated programatically Recommendation: Apply the [APG toggle button pattern](https://www.w3.org/WAI/ARIA/apg/patterns/button/) to things like the “Publish”; its use of `aria-pressed` will make sure assistive technologies known the status of the buttons. ![options toolbar with four toggle buttons](/attachments/997bd28f-fc7c-4388-a885-b38d2ebd0418) --- Note: the “B”, “I”, and “S” buttons in the “Editor toolbar” would usually also classify as toggle buttons. But it looks like these only activate formatting behaviour rather than also deactivating it. ![article reads “test”, no formatting](/attachments/330132c1-2697-4ba1-a648-f6f465d05cf1) 1. before “bold” activation ![article reads “test” which is bolded in markdown](/attachments/41060beb-4f28-401c-bdb4-946c05159c17) 2. after “bold” activation and selecting the text again ![article reads “test” with twice markdown bolding](/attachments/26738562-8019-4eee-8772-0628409115e9) 3. after activating “bold” once more, the markdown is added twice rather than deactivated

image.png

19 KiB

image.png

31 KiB

image.png

31 KiB

image.png

28 KiB

image.png

27 KiB

image.png

53 KiB